Fix relative line numbers showing in disabled mode#10052
Open
merdiofriviaisherebitch wants to merge 1 commit into
Open
Fix relative line numbers showing in disabled mode#10052merdiofriviaisherebitch wants to merge 1 commit into
merdiofriviaisherebitch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10006.
Summary of Changes:
src/mode/modeHandler.ts: SetinitialModeof newly createdModeHandlers toMode.Disabledifconfiguration.disableExtensionis true.extensionBase.ts:compositionStatedefinition to the top ofactivateso it can be referenced in earlier configuration change listeners.disableExtensionsetting changes, triggertoggleExtensionto update all editors.toggleExtension: when disabling, loop through all activeModeHandlers inModeHandlerMapand runmh.handleKeyEvent(SpecialKeys.ExtensionDisable)to transition them to Disabled mode (which reverts line numbers to absolute) before disposing them and clearing the map.toggleExtensionin thetoggleVimcommand handler to prevent race conditions.registerCommandwrapper toawait callback(args)to ensure async commands can be fully awaited in tests.test/configuration/configuration.test.ts: Added two unit tests to verify that new editors start with absolute line numbers whendisableExtensionis true, and that toggling the extension correctly toggles mode handler and updates line numbers style.tsconfig.json&package.json: Added"skipLibCheck": trueand pinned devDependencyglob: "^7.2.3"to resolve type definition and version conflicts during test compilation.